Skip to content

Added x86_64-unknown-hermit support#236

Merged
newpavlov merged 2 commits intorust-random:masterfrom
sjmackenzie:hermit-target
Dec 7, 2021
Merged

Added x86_64-unknown-hermit support#236
newpavlov merged 2 commits intorust-random:masterfrom
sjmackenzie:hermit-target

Conversation

@sjmackenzie
Copy link
Copy Markdown
Contributor

@sjmackenzie sjmackenzie commented Nov 27, 2021 •
edited
Loading

Later once hermit supports aarch64 rng I'll make a patch to support it.

For more context see #199

newpavlov
newpavlov approved these changes Nov 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@newpavlov newpavlov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I would prefer a proper buffer-based API, but I guess this code should be a fine stop-gap solution.

I will leave this PR open for some time in the case if @josephlr has any concerns.

Meanwhile can you please add an [UNRELEASED] section to the changelog with an entry containing description of this PR? Also it would be nice to add a Hermit build test to the CI workflow.

@sjmackenzie
Copy link
Copy Markdown
Contributor Author

sjmackenzie commented Nov 30, 2021 •
edited
Loading

Agreed on the buffer-based API, I suggest this is good feedback for @stlankes & @josephlr!

I believe getrandom CI already has hermit workflow support, correct me if I'm wrong please:

getrandom/.github/workflows/tests.yml

Line 312 in f5e3300

run: cargo build -Z build-std=core --features=rdrand --target=x86_64-unknown-hermit

Ideally I'd love to try get this stop-gap merged relatively soon as there are a number of transitive dependencies I need to lobby to bump to a hermit-supported-getrandom. I'm choosing hermit as the sole target platform for an existing project.

@josephlr I'd love your feedback on this stop-gap solution.

@newpavlov I pushed the requested changes, if you could be so kind and review them.

Thanks!

@sjmackenzie
Copy link
Copy Markdown
Contributor Author

sjmackenzie commented Nov 30, 2021

By buffer-based API do you mean you can pass in an arbitrary sized u8 buffer and it'd be filled accordingly? If so, this is what is happening in this PR.

@newpavlov
Copy link
Copy Markdown
Member

newpavlov commented Nov 30, 2021

By buffer-based API do you mean you can pass in an arbitrary sized u8 buffer and it'd be filled accordingly? If so, this is what is happening in this PR.

I meant a "syscall" on the Hermit side, like requested in hermit-os/kernel#143

I believe getrandom CI already has hermit workflow support, correct me if I'm wrong please:

Ah, I forgot about that. You can simply remove the --features=rdrand part then since it's not longer needed.

@newpavlov newpavlov merged commit ec445bb into rust-random:master Dec 7, 2021
@sjmackenzie
Copy link
Copy Markdown
Contributor Author

sjmackenzie commented Dec 13, 2021

Thanks for removing the --features=rdrand, it fell on the wayside. Appreciate the merge!

@sjmackenzie sjmackenzie deleted the hermit-target branch December 13, 2021 07:18
takumi-earth pushed a commit to earthlings-dev/getrandom that referenced this pull request Jan 27, 2026
@sjmackenzie
Added x86_64-unknown-hermit support (rust-random#236)
5a08ad2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjmackenzie @newpavlov
⚡